Implement pre-approval flow in btc-staker #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazar955
reviewed
Oct 9, 2024
| @@ -126,6 +126,10 @@ var stakeCmd = cli.Command{ | |||
| Usage: "Staking time in BTC blocks", | |||
| Required: true, | |||
| }, | |||
| cli.BoolFlag{ | |||
| Name: helpers.SendToBabylonFirstFlag, | |||
| Usage: "Wheter staking transaction should be first to Babylon or BTC", | |||
There was a problem hiding this comment.
Suggested change
| Usage: "Wheter staking transaction should be first to Babylon or BTC", | |
| Usage: "Whether staking transaction should be first to Babylon or BTC", |
itest/e2e_test.go
Outdated
| @@ -1451,7 +1535,7 @@ func TestStakingUnbonding(t *testing.T) { | |||
| tm.waitForStakingTxState(t, txHash, proto.TransactionState_SPENT_ON_BTC) | |||
| } | |||
|
|
|||
| func TestUnbondingRestartWaitingForSignatures(t *testing.T) { | |||
| func AestUnbondingRestartWaitingForSignatures(t *testing.T) { | |||
There was a problem hiding this comment.
Suggested change
| func AestUnbondingRestartWaitingForSignatures(t *testing.T) { | |
| func TestUnbondingRestartWaitingForSignatures(t *testing.T) { |
staker/babylontypes.go
Outdated
| // - delegation is on babylon | ||
| // - delegation has received enough covenant signatures | ||
| func (app *StakerApp) activateVerifiedDelegation( | ||
| stakerAddress btcutil.Address, |
There was a problem hiding this comment.
stakerAddress seems to be unused
Lazar955
approved these changes
Oct 9, 2024
RafilxTenfen
reviewed
Oct 9, 2024
staker/babylontypes.go
Outdated
| @@ -133,7 +138,7 @@ func (app *StakerApp) buildDelegation( | |||
| stakerAddress btcutil.Address, | |||
| storedTx *stakerdb.StoredTransaction) (*cl.DelegationData, error) { | |||
|
|
|||
| stakingTxInclusionProof := app.mustBuildInclusionProof(req) | |||
| // stakingTxInclusionProof := app.mustBuildInclusionProof(req) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements pre-approval flow in btc staker.
There is new config option
CheckActiveInterval(cc: @filippos47 )In general this is basic support which assumes there is vigiliante in the network that wil provide the proof on inclusion at some point in time.
At this time two flows are supported, to use pre-approval flow staker must provide flag:
--send-to-babylon-first=trueAt least two follow up tasks (which is not blocking for devnet2):